fix(boards): Select hummingbird physical layout #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Munnich
force-pushed
the
hummingbird-fix
branch
from
ca4905e
to
f1de8e4
Compare
Nick-Munnich
force-pushed
the
hummingbird-fix
branch
from
f1de8e4
to
e378286
Compare
|
I think if we're not explicit about it everywhere, then this needs to be documented. I'd prefer to be explicit everywhere to avoid needing to document it, but I'm also always biased towards "one way to do it". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The physical layout was defined previously, but never selected in the chosen node. I did not verify the correctness of the physical layout and matrix transform.